fix: consent-verbose code example #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinckr
requested review from
aeneasr,
zepatrik,
piotrmsc and
Benehiko
as code owners
Benehiko
reviewed
Jul 17, 2023
There was a problem hiding this comment.
This looks okay, maybe use this instead? https://github.com/ory/kratos-selfservice-ui-node/blob/master/src/routes/consent.ts
The kratos-selfservice-ui-node is more up to date i think.
the consent-verbose example was a copy of login-verbose. This patch changes it a correct example code
vinckr
force-pushed
the
vinckr-patch-4124-docs
branch
from
a30ca27
to
2a6406b
Compare
Hm its a good 100 lines longer. But then again it is the verbose example 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the consent-verbose example is a copy of login-verbose. This patch changes it a correct example code.
https://www.ory.sh/docs/oauth2-oidc/custom-login-consent/flow#consent-endpoint-code-example
I am not 100% sure if this is the correct code example, but that was what we had before from https://github.com/ory/hydra-login-consent-node/blob/master/src/routes/consent.ts
Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments